[webkit-reviews] review denied: [Bug 76203] [chromium] Fix DC leak in WebScreenInfoFactory. : [Attachment 122315] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 15:05:54 PST 2012


Dmitry Titov <dimich at chromium.org> has denied David Levin
<levin at chromium.org>'s request for review:
Bug 76203: [chromium] Fix DC leak in WebScreenInfoFactory.
https://bugs.webkit.org/show_bug.cgi?id=76203

Attachment 122315: Patch
https://bugs.webkit.org/attachment.cgi?id=122315&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122315&action=review


Chromium will live! One note:

> Source/JavaScriptCore/JavaScriptCore.gyp/JavaScriptCore.gyp:176
> +	       ['include', 'win/OwnPtrWin\\.cpp$'],

Could we only have changes directly related to the DC fix? It would be easier
to understand the patch.

> Source/JavaScriptCore/wtf/OwnPtrCommon.h:31
> +#if OS(WIN)

Same as above.


More information about the webkit-reviews mailing list