[webkit-reviews] review granted: [Bug 76196] Move snapRubberBandTimerFired to ScrollElasticityController : [Attachment 122279] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 12 12:02:11 PST 2012
Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 76196: Move snapRubberBandTimerFired to ScrollElasticityController
https://bugs.webkit.org/show_bug.cgi?id=76196
Attachment 122279: Patch
https://bugs.webkit.org/attachment.cgi?id=122279&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122279&action=review
> Source/WebCore/ChangeLog:8
> + No new tests. (OOPS!)
OOPS!
> Source/WebCore/platform/mac/ScrollElasticityController.mm:95
> + if (!m_momentumScrollInProgress || m_ignoreMomentumScrolls) {
We could reverse this condition and do an early return to reduce nesting.
More information about the webkit-reviews
mailing list