[webkit-reviews] review denied: [Bug 53644] [GTK] editing/deleting/5408255.html results are incorrect : [Attachment 120476] WIP Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied  review:
Bug 53644: [GTK] editing/deleting/5408255.html results are incorrect
https://bugs.webkit.org/show_bug.cgi?id=53644

Attachment 120476: WIP Patch
https://bugs.webkit.org/attachment.cgi?id=120476&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=120476&action=review


Okay. This seems like a nice fix. r- here because it should be possible to get
something close-to-right on Windows without building and because this breaks
WebKitTestRunner. Let me know if you need tips for testing WKTR.

> Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:51
> +static const char* getDataPathForResource()

You need to fix this up a bit. The signature should be: static char*
getDataPathForResource(const char* resource). Later on you should use the
resource name to find the image.

> Source/WebCore/platform/graphics/gtk/ImageGtk.cpp:78
> +static char* getDataPathForResource(char* resource)

You should probably rename this to something like getPathToImage now. The
argument should be a const char*.

> Tools/GNUmakefile.am:76
> +	-DTOP_LEVEL_DIR=\"${shell pwd}/${srcdir}\" \

You need to do something similar for WebKitTestRunner too if you are going to
no longer set this environment variable.