[webkit-reviews] review granted: [Bug 75983] Refactor RenderLayerBacking::paintIntoLayer and RenderLayer::paintLayer()/paintLayerContents() to avoid duplicate code : [Attachment 122243] Patch V1

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 75983: Refactor RenderLayerBacking::paintIntoLayer and
RenderLayer::paintLayer()/paintLayerContents() to avoid duplicate code
https://bugs.webkit.org/show_bug.cgi?id=75983

Attachment 122243: Patch V1
https://bugs.webkit.org/attachment.cgi?id=122243&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122243&action=review


> Source/WebCore/rendering/RenderLayer.cpp:2724
> +    // PaintLayerAppliedTransform is still being used for RenderReplica.

This comment is a bit confusing. It's not clear to me if it's a FIXME or what.

> Source/WebCore/rendering/RenderLayer.h:442
> +	   PaintLayerPaintingBackgroundPhase = 1 << 5,
> +	   PaintLayerPaintingForegroundPhase = 1 << 6,
> +	   PaintLayerPaintingMaskPhase = 1 << 7,

I think it might help to have 'compositing' in these names.
PaintLayerPaintingCompositingBackgroundPhase etc.