[webkit-reviews] review denied: [Bug 76155] Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia : [Attachment 122187] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 10:11:44 PST 2012


Tony Chang <tony at chromium.org> has denied Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 76155: Move SimpleFontDataSkia.cpp to Source/WebCore/platform/graphics/skia
https://bugs.webkit.org/show_bug.cgi?id=76155

Attachment 122187: Patch
https://bugs.webkit.org/attachment.cgi?id=122187&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122187&action=review


> Source/WebCore/WebCore.gyp/WebCore.gyp:1710
> -	       ['include',
'platform/graphics/harfbuzz/SimpleFontDataSkia\\.cpp$'],
> +	       ['include', 'platform/graphics/skia/SimpleFontDataSkia\\.cpp$'],


I think you also need to exclude the file on mac and win.  The mac code is
around line 1661 and the win code is around line 1692.


More information about the webkit-reviews mailing list