[webkit-reviews] review granted: [Bug 76147] [Chromium] JSExportMacros.h should be visible. : [Attachment 122171] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 12 10:03:56 PST 2012


Tony Chang <tony at chromium.org> has granted MORITA Hajime <morrita at google.com>'s
request for review:
Bug 76147: [Chromium] JSExportMacros.h should be visible.
https://bugs.webkit.org/show_bug.cgi?id=76147

Attachment 122171: Patch
https://bugs.webkit.org/attachment.cgi?id=122171&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122171&action=review


> Source/JavaScriptCore/config.h:37
> +// Chromium doesn't have runtime/ in its include paths.
> +#include "runtime/JSExportMacros.h"

Should we add runtime/ to the include path for yarr?  Actually, it looks like
it's already there for the yarr target.  Should we add it to
direct_dependent_settings?


More information about the webkit-reviews mailing list