[webkit-reviews] review denied: [Bug 75958] nrwt should use multiple http shards : [Attachment 122223] add --max-locked-shard option

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has denied	review:
Bug 75958: nrwt should use multiple http shards
https://bugs.webkit.org/show_bug.cgi?id=75958

Attachment 122223: add --max-locked-shard option
https://bugs.webkit.org/attachment.cgi?id=122223&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
r-, because it broke a unittest. :-/

ERROR: test_shard_by_dir
(webkitpy.layout_tests.controllers.manager_unittest.ShardingTests)
----------------------------------------------------------------------
Traceback (most recent call last):
  File
"/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unit
test.py", line 82, in test_shard_by_dir
    locked, unlocked = self.get_shards(num_workers=2, fully_parallel=False)
  File
"/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager_unit
test.py", line 79, in get_shards
    return self.manager._shard_tests(test_list, num_workers, fully_parallel)
  File
"/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py",
line 593, in _shard_tests
    return self._shard_by_directory(test_files, num_workers)
  File
"/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py",
line 664, in _shard_by_directory
    'locked_shard'),
  File
"/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py",
line 706, in _resize_shards
    num_old_per_new = divide_and_round_up(len(old_shards), max_new_shards)
  File
"/home/oszi/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py",
line 695, in divide_and_round_up
    return int(math.ceil(float(numerator) / divisor))
TypeError: unsupported operand type(s) for /: 'float' and 'Mock'

Could you check it and fix?