[webkit-reviews] review denied: [Bug 76043] CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code : [Attachment 121998] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Roland Steiner
<rolandsteiner at chromium.org>'s request for review:
Bug 76043: CSSStyleSelector constructor and appendAuthorStylesheets() contain
duplicated code
https://bugs.webkit.org/show_bug.cgi?id=76043

Attachment 121998: Patch
https://bugs.webkit.org/attachment.cgi?id=121998&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
I don't think this is right factoring. We will need to do collectFeatures
differently in append case to avoid going through all the stylesheets again. We
don't generally use iterators with Vectors. I'd like to eliminate the pointless
StyleSheetVector typedef.