[webkit-reviews] review granted: [Bug 75080] [Chromium] [WebSocket] Add WebArrayBuffer support in WebSocket to WebKit API : [Attachment 121807] Patch

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Takashi
Toyoshima <toyoshim at chromium.org>'s request for review:
Bug 75080: [Chromium] [WebSocket] Add WebArrayBuffer support in WebSocket to
WebKit API
https://bugs.webkit.org/show_bug.cgi?id=75080

Attachment 121807: Patch
https://bugs.webkit.org/attachment.cgi?id=121807&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121807&action=review


> Source/WebKit/chromium/src/WebSocketImpl.cpp:131
> +    return m_private->send(*static_cast<PassRefPtr<ArrayBuffer>
>(webArrayBuffer));

nit: we usually use PassRefPtr<ArrayBuffer>(webArrayBuffer) in cases like this.

i.e., construct a PassRefPtr.  of course, the compiler will invoke the casting
operator, and as such it'll result in the same code you have here.  it just
looks a bit cleaner as a call to the PassRefPtr constructor.