[webkit-reviews] review granted: [Bug 76103] Implement font-variant-ligatures: {no-}common-ligatures : [Attachment 122101] Parse font-variant-ligatures and respect the common-ligatures value keywords

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted mitz at webkit.org's request for review:
Bug 76103: Implement font-variant-ligatures: {no-}common-ligatures
https://bugs.webkit.org/show_bug.cgi?id=76103

Attachment 122101: Parse font-variant-ligatures and respect the
common-ligatures value keywords
https://bugs.webkit.org/attachment.cgi?id=122101&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122101&action=review


> Source/WebCore/css/CSSStyleApplyProperty.cpp:759
> +	   if (value->isPrimitiveValue())
> +	       ASSERT(static_cast<CSSPrimitiveValue*>(value)->getIdent() ==
CSSValueNormal);

This seems like it should go in the else block within an !ASSERTIONS_DISABLED.

> Source/WebCore/platform/graphics/FontDescription.h:196
> +    unsigned m_commonLigaturesState : 3;
> +    unsigned m_discretionaryLigaturesState : 3;
> +    unsigned m_historicalLigaturesState : 3;

Do you really need three bits here?