[webkit-reviews] review granted: [Bug 62320] Emit an error event when a request to enter full-screen is rejected. : [Attachment 122090] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 62320: Emit an error event when a request to enter full-screen is rejected.
https://bugs.webkit.org/show_bug.cgi?id=62320

Attachment 122090: Patch
https://bugs.webkit.org/attachment.cgi?id=122090&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=122090&action=review


> Source/WebCore/ChangeLog:12
> +	   (webkitfullscreenrequesterror) in response.	But emit the event
during the next

Don't you mean webkitfullscreenerror?

> Source/WebCore/ChangeLog:17
> +	   (WebCore::Document::Document): Add initializers for new timer.

Didn't you remove the new timer?

> Source/WebCore/ChangeLog:21
> +	   * dom/Document.idl: Add support for setting an onfullscreenerror
attribute.

Isn't it onwebkitfullscreenerror?

> Source/WebCore/dom/Document.cpp:5209
> +    while (!m_fullScreenErrorEventTargetQueue.isEmpty()) {
> +	   RefPtr<Element> element =
m_fullScreenErrorEventTargetQueue.takeFirst();
> +	   if (!element)
> +	       element = documentElement();

Can takeFirst() return 0 when the queue is not empty?