[webkit-reviews] review granted: [Bug 75959] Add RenderStyle::isPositioned() helper method : [Attachment 122086] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 11 13:45:58 PST 2012


Tony Chang <tony at chromium.org> has granted Mihnea Ovidenie <mihnea at adobe.com>'s
request for review:
Bug 75959: Add RenderStyle::isPositioned() helper method
https://bugs.webkit.org/show_bug.cgi?id=75959

Attachment 122086: Patch 2
https://bugs.webkit.org/attachment.cgi?id=122086&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122086&action=review


> Source/WebCore/rendering/RenderObject.cpp:629
> +	   if (!last->isText() && (last->style()->isPositioned())) {

Nit: Remove extra ()s.

> Source/WebCore/rendering/RenderObject.cpp:669
> +    if (b && !alreadyDirty && markParents && (isText() ||
(!style()->isPositioned())))

Nit: Remove extra ()s.


More information about the webkit-reviews mailing list