[webkit-reviews] review denied: [Bug 73215] Split QWebPermissionRequest into QWebSecurityOrigin : [Attachment 122049] Imported code, implemented missing methods/operators, integrated with QWebPermissionRequest

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Adenilson Cavalcanti
Silva <savagobr at yahoo.com>'s request for review:
Bug 73215: Split QWebPermissionRequest into QWebSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=73215

Attachment 122049: Imported code, implemented missing methods/operators,
integrated with QWebPermissionRequest
https://bugs.webkit.org/attachment.cgi?id=122049&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122049&action=review


No qml example?

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:37
> +// Look at webkit1 on how to do this properly.
> +// These needs to be in sync at web process start up and send over when
changed.
> +static QStringList s_localSchemes;

This seems to need fixing

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:45
> +	   s_localSchemes.clear();
> +	   const URLSchemesMap& map = SchemeRegistry::localSchemes();

If SchemeRegistry::localSchemes already exists any reason for s_localSchemes?

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:48
> +	   URLSchemesMap::const_iterator end = map.end();
> +	   for (URLSchemesMap::const_iterator i = map.begin(); i != end; ++i) {

> +	       const QString scheme = *i;

we use 'it' for real iterators, not i

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:56
> +    QtWebSecurityOriginPrivate()
> +    {
> +	   localSchemes();
> +    }

Would need a comment

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:63
> +
> +    QUrl url;
> +};

why is this public? why not a real property?

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:77
> +    // FIXME: how to say if a scheme is local or not?
> +    Q_UNUSED(scheme)
> +    return true;
> +}
> +
> +QtWebSecurityOrigin::QtWebSecurityOrigin(const QUrl& url, QObject *parent)
> +    : QObject(parent)
> +    , d(new QtWebSecurityOriginPrivate)
> +{
> +    if (s_localSchemes.empty())
> +	   s_localSchemes << QLatin1String("file") << QLatin1String("qrc");

you have local schemes here... I dont understand the commetn

coding style issue (* placement)

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin.cpp:166
> +    // FIXME: Might need some versioning.
> +    out << (origin.url().toEncoded().data());
> +    return out;

Some comment needs to explain why the url is enough

> Source/WebKit2/UIProcess/API/qt/qtwebsecurityorigin_p.h:40
> +    QtWebSecurityOrigin(const QUrl& url, QObject *parent = 0);

* placement

> Source/WebKit2/UIProcess/API/qt/qwebpermissionrequest.cpp:35
> +	   , sameOrigin(QUrl(), 0)

sameOrigin? weird name