[webkit-reviews] review granted: [Bug 76086] Be more aggressive about deleting unnecessary results from the test-results-server json files : [Attachment 122061] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 76086: Be more aggressive about deleting unnecessary results from the
test-results-server json files
https://bugs.webkit.org/show_bug.cgi?id=76086

Attachment 122061: Patch
https://bugs.webkit.org/attachment.cgi?id=122061&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122061&action=review


> Tools/TestResultServer/model/jsonresults.py:212
> +	   deletable_types = set([JSON_RESULTS_PASS, JSON_RESULTS_NO_DATA,
JSON_RESULTS_SKIP])

Nit: tuple instead of list: set((JSON_RESULTS_PASS, JSON_RESULTS_NO_DATA,
JSON_RESULTS_SKIP))

> Tools/TestResultServer/model/jsonresults.py:214
> +	   for result in aggregated_test[JSON_RESULTS_RESULTS]:
> +	       if result[1] not in deletable_types:

Not sure if it's any better, but this could be:
if any((1 for result in aggregated_test[JSON_RESULTS_RESULTS] if result[1] not
in deletable_types)):