[webkit-reviews] review granted: [Bug 76040] [v8] Int16Array.set(array, offset) fails on first execution : [Attachment 121997] Pass the offset argument to copyElements

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Ulan Degenbaev
<ulan at chromium.org>'s request for review:
Bug 76040: [v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040

Attachment 121997: Pass the offset argument to copyElements
https://bugs.webkit.org/attachment.cgi?id=121997&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121997&action=review


Fix looks good. Is it possible to also incorporate tests for this into the
array-unit-tests.html test? If not (because it only happens the first time
set() is called for each view type) then the separate test case is fine.
Marking cq- until this question is answered.

> ChangeLog:6
> +	   Reviewed by Kenneth Russell.

Leave the "Reviewed by NOBODY" line alone when uploading patches. The commit
process patches it up automatically.