[webkit-reviews] review granted: [Bug 76080] Webpages flash white when switching between windows : [Attachment 122057] Patch

[bugzilla-daemon at webkit.org]

mitz at webkit.org has granted Anders Carlsson <andersca at apple.com>'s request for
review:
Bug 76080: Webpages flash white when switching between windows
https://bugs.webkit.org/show_bug.cgi?id=76080

Attachment 122057: Patch
https://bugs.webkit.org/attachment.cgi?id=122057&action=review

------- Additional Comments from mitz at webkit.org
View in context: https://bugs.webkit.org/attachment.cgi?id=122057&action=review


> Source/WebKit2/ChangeLog:9
> +	   Introduce a _windowHasValidBackingStore boolean and only paint white
if it's false.

Is it really unconditionally white?

> Source/WebKit2/ChangeLog:17
> +	   * UIProcess/API/mac/WKView.mm:
> +	   (-[WKView setFrameSize:]):
> +	   (-[WKView viewDidMoveToWindow]):
> +	   (-[WKView _windowDidMiniaturize:]):
> +	   (-[WKView _windowDidChangeBackingProperties:]):
> +	   (-[WKView drawRect:]):
> +

Please add comments here.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:192
> +    // The window server invalidates the backing store of whenever the
window is resized or minimized.

Typo: “of whenever”.

> Source/WebKit2/UIProcess/API/mac/WKView.mm:1980
> +	       // didn't paint with white, to avoid garbage in those areas.

Is it really always white?