[webkit-reviews] review granted: [Bug 76039] Rename HTMLInputElement::setDefaultName to setInitialName : [Attachment 121994] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 11 10:15:17 PST 2012


Darin Adler <darin at apple.com> has granted Kent Tamura <tkent at chromium.org>'s
request for review:
Bug 76039: Rename HTMLInputElement::setDefaultName to setInitialName
https://bugs.webkit.org/show_bug.cgi?id=76039

Attachment 121994: Patch
https://bugs.webkit.org/attachment.cgi?id=121994&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121994&action=review


> Source/WebCore/html/HTMLInputElement.cpp:1305
> +    ASSERT(hasTagName(isindexTag));

To me it seems like this assert goes a little overboard, but only a tiny bit,
so I say, lets keep it.


More information about the webkit-reviews mailing list