[webkit-reviews] review granted: [Bug 76056] Web Inspector: make setOuterHTML use new DOMEditor, cover it with tests. : [Attachment 122013] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 76056: Web Inspector: make setOuterHTML use new DOMEditor, cover it with
tests.
https://bugs.webkit.org/show_bug.cgi?id=76056

Attachment 122013: Patch
https://bugs.webkit.org/attachment.cgi?id=122013&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=122013&action=review


> Source/WebCore/inspector/DOMEditor.cpp:55
> +    Digest(Node* node) : m_node(node) { }

missing explicit modifier

> Source/WebCore/inspector/DOMEditor.cpp:114
> +	       *errorString = "DOMException: failed to set outer html.";

Can you return DOM exception description here?

> Source/WebCore/inspector/DOMEditor.cpp:162
>      if (oldDigest->m_node->nodeType() != Node::ELEMENT_NODE)

oldNode->nodeType() != Node::ELEMENT_NODE