[webkit-reviews] review denied: [Bug 75553] [GTK][WK2] Initial FullScreen support : [Attachment 121284] Patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 75553: [GTK][WK2] Initial FullScreen support
https://bugs.webkit.org/show_bug.cgi?id=75553

Attachment 121284: Patch
https://bugs.webkit.org/attachment.cgi?id=121284&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121284&action=review


Not a full review, but here are a few things I noticed.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebViewBase.cpp:80
> +#if ENABLE(FULLSCREEN_API)
> +    RefPtr<FullScreenWindowController> fullScreenWindowController;
> +#endif
>  };

This doesn't actually need to be allocated on the heap. You can just do:
FullScreenWindowController fullScreenWindowController;

Be sure that it's still noncopyable though.

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.cpp:32
> +#include <WebCore/PlatformScreen.h>
> +
> +#include <gdk/gdk.h>

No extra newline necessary here.

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:25
> +

Extra newline here.

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:32
> +class FullScreenWindowController : public
RefCounted<FullScreenWindowController> {

I think this can just extend from Noncopyable abfter the change above.

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:33
> +protected:

Why protected?

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:37
> +    virtual ~FullScreenWindowController();

- should probably be ~ here. :)

> Source/WebKit2/UIProcess/gtk/FullScreenWindowController.h:56
> +#endif
> +
> +#endif

For C++ files usually we do something like:

#endif // ENABLE(FULLSCREEN)

#endif // FullScreenWindowController_h