[webkit-reviews] review granted: [Bug 75882] [Qt][WK2] Directly-composited images sometimes appear with a wrong geometry : [Attachment 121711] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 11 06:30:02 PST 2012


Simon Hausmann <hausmann at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 75882: [Qt][WK2] Directly-composited images sometimes appear with a wrong
geometry
https://bugs.webkit.org/show_bug.cgi?id=75882

Attachment 121711: Patch
https://bugs.webkit.org/attachment.cgi?id=121711&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121711&action=review


r=me but I think you should also remove the comment before landing.

> Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp:421
> -    m_layerInfo.drawsContent = drawsContent() || m_image;
> +    m_layerInfo.drawsContent = drawsContent();

Ahah, now I see why you removed the comment in the other patch. It seems that
the comment removal should be taken from the other patch and moved over here ;)


More information about the webkit-reviews mailing list