[webkit-reviews] review requested: [Bug 76040] [v8] Int16Array.set(array, offset) fails on first execution : [Attachment 121997] Pass the offset argument to copyElements
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 11 02:36:44 PST 2012
Ulan Degenbaev <ulan at chromium.org> has asked for review:
Bug 76040: [v8] Int16Array.set(array, offset) fails on first execution
https://bugs.webkit.org/show_bug.cgi?id=76040
Attachment 121997: Pass the offset argument to copyElements
https://bugs.webkit.org/attachment.cgi?id=121997&action=review
------- Additional Comments from Ulan Degenbaev <ulan at chromium.org>
Ken, could you please take a look?
The problem was that I missed the offset argument when calling copyElements.
It passed the unit-tests because the fast set() method happened to be installed
when calling set() with offset.
I added a separate test which calls the set with a valid offset at the
beginning. There is not need for testing invalid offset because in such case
copyElements is not called at all.
More information about the webkit-reviews
mailing list