[webkit-reviews] review granted: [Bug 65711] Large SVG text layout performance regression in r81168 : [Attachment 121876] Patch chunk 1, v9
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jan 11 01:01:24 PST 2012
Zoltan Herczeg <zherczeg at webkit.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 65711: Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711
Attachment 121876: Patch chunk 1, v9
https://bugs.webkit.org/attachment.cgi?id=121876&action=review
------- Additional Comments from Zoltan Herczeg <zherczeg at webkit.org>
r=me
View in context: https://bugs.webkit.org/attachment.cgi?id=121876&action=review
Just one note:
> Source/WebCore/platform/graphics/Font.h:229
> + bool textRunNeedsComplexCodePath(const TextRun& run) const { return
codePath(run) == Complex; }
> +
I think codePath should be made public. The enum is already public, and this
makes the function "half" public.
More information about the webkit-reviews
mailing list