[webkit-reviews] review denied: [Bug 75867] Compilation errors on build-webkit --debug --no-video --no-fullscreen-api on mac. : [Attachment 121911] leave out --no-fullscreen issues.

[bugzilla-daemon at webkit.org]

Philippe Normand <pnormand at igalia.com> has denied Pablo Flouret
<pablof at motorola.com>'s request for review:
Bug 75867: Compilation errors on build-webkit --debug --no-video
--no-fullscreen-api on mac.
https://bugs.webkit.org/show_bug.cgi?id=75867

Attachment 121911: leave out --no-fullscreen issues.
https://bugs.webkit.org/attachment.cgi?id=121911&action=review

------- Additional Comments from Philippe Normand <pnormand at igalia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121911&action=review


Can you please elaborate the ChangeLog entries instead of copy/pasting the same
message?

> Source/WebCore/rendering/RenderThemeMac.h:176
> -#endif
> -    
>      virtual bool shouldShowPlaceholderWhenFocused() const;
> +#endif

I might be wrong here, but I think this method was added under the wrong guard
in the first place. It's used only in the HTMLTextFormControlElement from what
I can tell, which has nothing to do with VIDEO.

> Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:947
> +void WebChromeClient::fullScreenRendererChanged(RenderBox* renderer)

This method should not be under VIDEO, it is guarded by FULLSCREEN_API in
ChromeClient.h.