[webkit-reviews] review granted: [Bug 76011] last-green-revision should give us per-bot information : [Attachment 121957] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 76011: last-green-revision should give us per-bot information
https://bugs.webkit.org/show_bug.cgi?id=76011

Attachment 121957: Patch
https://bugs.webkit.org/attachment.cgi?id=121957&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121957&action=review


> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:436
> +	   builder_page_url = "%s/builders/%s?numbuilds=100" %
(self.buildbot_url, builder.name().replace(' ', '%20'))

replace(' ', '%20') => does we need to use some more general URL encoding
function?

> Tools/Scripts/webkitpy/common/net/buildbot/buildbot.py:443
> +	   for status_row in soup.find('table').findAll('tr'):

Should we be using the JSON API instead?

> Tools/Scripts/webkitpy/tool/bot/irc_command.py:60
> +	   return "%s: %s" % (nick,
urls.view_revision_url(tool.buildbot.last_green_revision(args[0])))

view_revision_url still right?	last_green_revision seems to return a string
now, not a revision number.