[webkit-reviews] review granted: [Bug 75977] [GTK] Linking of big binaries should be serialized to avoid thrashing : [Attachment 121878] Proposed patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 75977: [GTK] Linking of big binaries should be serialized to avoid
thrashing
https://bugs.webkit.org/show_bug.cgi?id=75977

Attachment 121878: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=121878&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121878&action=review


This is awesome.

> Source/WebKit2/GNUmakefile.am:1017
> +WEBKIT2GTKLIBFORDEP =
libwebkit2gtk- at WEBKITGTK_API_MAJOR_VERSION@. at WEBKITGTK_API_MINOR_VERSION@.la

We've been using names_like_this recently in automake files. Do you mind
changing this to something like webkit2gtk_lib_for_dep

> Source/WebKit2/GNUmakefile.am:1280
> +# Serialize linking of the plugin process with both webkit libraries

Super nit: missing a period at the end of this line.

> Source/WebKit2/GNUmakefile.am:1281
> +PLUGINPROCFORDEP = Programs/WebKitPluginProcess

Ditto with the caps.