[webkit-reviews] review denied: [Bug 47036] Wheel scrolls and autoscrolls should not scroll overflow:hidden : [Attachment 95929] Followon patch v9

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 10 18:49:16 PST 2012


Eric Seidel <eric at webkit.org> has denied Peter Kasting <pkasting at google.com>'s
request for review:
Bug 47036: Wheel scrolls and autoscrolls should not scroll overflow:hidden
https://bugs.webkit.org/show_bug.cgi?id=47036

Attachment 95929: Followon patch v9
https://bugs.webkit.org/attachment.cgi?id=95929&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=95929&action=review

Seems like this needs a refresh to be landed.

>> Source/WebCore/dom/Node.cpp:2819
>> +		while (renderer && (!renderer->isBox() ||
!toRenderBox(renderer)->canBeScrolledAndHasScrollableArea(true)))
> 
> I wonder what that true means, coudl you add /* description */ true ?

In general when that's the case, we should be usign an enum instead of a bool.


More information about the webkit-reviews mailing list