[webkit-reviews] review granted: [Bug 76004] Use the [Supplemental] IDL in SQLDatabase : [Attachment 121932] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 76004: Use the [Supplemental] IDL in SQLDatabase
https://bugs.webkit.org/show_bug.cgi?id=76004

Attachment 121932: Patch
https://bugs.webkit.org/attachment.cgi?id=121932&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121932&action=review


> Source/WebCore/storage/DOMWindowSQLDatabase.cpp:46
> +PassRefPtr<Database> DOMWindowSQLDatabase::openDatabase(DOMWindow* imp,
const String& name, const String& version, const String& displayName, unsigned
long estimatedSize, PassRefPtr<DatabaseCallback> creationCallback,
ExceptionCode& ec)

Maybe |imp| should be |window| ?  We like to use more specific names outside of
the bindings.

> Source/WebCore/storage/DOMWindowSQLDatabase.cpp:52
> +    if (imp->frame() && AbstractDatabase::isAvailable() &&
imp->frame()->document()->securityOrigin()->canAccessDatabase())

imp->frame() will always be true when imp->isCurrentlyDisplayedInFrame() is
true.

imp->frame()->document() can just be imp->document()	(there's no reason to
indirect through the frame)

Feel free to leave the code as-is since you're just moving it.	Maybe we should
just add FIXME comments about these nits?

> Source/WebCore/storage/DOMWindowSQLDatabase.h:51
> +};

Can you make the constructor and destructor private?