[webkit-reviews] review denied: [Bug 75922] [chromium] Fix navigation start time on cross-renderer navigation : [Attachment 121776] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 10 13:58:28 PST 2012
Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied James Simonsen
<simonjam at chromium.org>'s request for review:
Bug 75922: [chromium] Fix navigation start time on cross-renderer navigation
https://bugs.webkit.org/show_bug.cgi?id=75922
Attachment 121776: Patch
https://bugs.webkit.org/attachment.cgi?id=121776&action=review
------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121776&action=review
> Source/WebKit/chromium/src/WebFrameImpl.cpp:1093
> + FrameLoader* frameLoader = m_frame->loader();
yeah, since your implementation just pokes the DocumentLoader, this clearly
needs
to be a method on WebDataSource instead.
More information about the webkit-reviews
mailing list