[webkit-reviews] review granted: [Bug 75988] [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test : [Attachment 121899] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 10 13:36:18 PST 2012


Adam Barth <abarth at webkit.org> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 75988: [chromium] Run webkit_unit_tests as part of webkit-patch
build-and-test
https://bugs.webkit.org/show_bug.cgi?id=75988

Attachment 121899: Patch
https://bugs.webkit.org/attachment.cgi?id=121899&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121899&action=review


> Tools/Scripts/webkitpy/common/config/ports.py:249
> +	   command = cls.script_shell_command("run-chromium-webkit-unit-tests")

> +	   return command

I would have combined these lines.

> Tools/Scripts/webkitpy/tool/steps/runtests.py:69
> +

Looks like you have an extra blank line here.


More information about the webkit-reviews mailing list