[webkit-reviews] review granted: [Bug 75533] Move the check for canExecuteScripts out of V8Proxy::retrieve : [Attachment 121561] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted jochen at chromium.org's request for
review:
Bug 75533: Move the check for canExecuteScripts out of V8Proxy::retrieve
https://bugs.webkit.org/show_bug.cgi?id=75533

Attachment 121561: Patch
https://bugs.webkit.org/attachment.cgi?id=121561&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121561&action=review


> Source/WebCore/bindings/v8/ScheduledAction.cpp:100
> +	   if (!scriptController->canExecuteScripts(NotAboutToExecuteScript))

Shouldn't this be AboutToExecuteScript?  We're calling execute two lines
down...

> Source/WebCore/bindings/v8/V8EventListener.cpp:88
> +	   if (frame->script()->canExecuteScripts(NotAboutToExecuteScript))

Isn't this AboutToExecuteScript?  We're calling a function on the next line.

> Source/WebCore/bindings/v8/V8LazyEventListener.cpp:70
> +	   if (frame->script()->canExecuteScripts(NotAboutToExecuteScript))

ditto