[webkit-reviews] review denied: [Bug 74176] [Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash : [Attachment 121857] Updated patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 74176: [Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show()
crash
https://bugs.webkit.org/show_bug.cgi?id=74176

Attachment 121857: Updated patch
https://bugs.webkit.org/attachment.cgi?id=121857&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121857&action=review


Some nitpicks, almost there.

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:249
> +	       GLContextDataMap::const_iterator mapEnd =
glContextDataMap().end();

Use end instead of mapEnd

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:408
>  void TextureMapperGL::initializeShaders()

I think we should move this function into SharedData constructor, would save us
lots of code.