[webkit-reviews] review granted: [Bug 75960] [skia] not all convex paths are convex, so recompute convexity for the problematic ones : [Attachment 121844] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 10 09:17:55 PST 2012


Stephen White <senorblanco at chromium.org> has granted Mike Reed
<reed at google.com>'s request for review:
Bug 75960: [skia] not all convex paths are convex, so recompute convexity for
the problematic ones
https://bugs.webkit.org/show_bug.cgi?id=75960

Attachment 121844: Patch
https://bugs.webkit.org/attachment.cgi?id=121844&action=review

------- Additional Comments from Stephen White <senorblanco at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121844&action=review


Looks good.  r=me

> Source/WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:451
> +    if (4 == numPoints)

Nit:  WebKit style doesn't use the reversed == operands.


More information about the webkit-reviews mailing list