[webkit-reviews] review granted: [Bug 75348] Use HashMap<OwnPtr> for RenderBoxRegionInfo map in RenderRegion : [Attachment 121781] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Caio Marcelo de Oliveira Filho
<cmarcelo at webkit.org>'s request for review:
Bug 75348: Use HashMap<OwnPtr> for RenderBoxRegionInfo map in RenderRegion
https://bugs.webkit.org/show_bug.cgi?id=75348

Attachment 121781: Patch
https://bugs.webkit.org/attachment.cgi?id=121781&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121781&action=review


> Source/WebCore/rendering/RenderFlowThread.cpp:669
> -	   delete oldInfo;
> +	   oldInfo.clear();

I’m not sure it’s necessary to do this explicitly. The delete was needed
before, but an OwnPtr takes care of this even if you don’t clear explicitly.
I’d be tempted to just leave it out.

> Source/WebCore/rendering/RenderRegion.cpp:228
>  void RenderRegion::deleteAllRenderBoxRegionInfo()

The call to this function in the destructor is no longer needed. In fact, the
destructor need not be declared or defined at all any more, since the default
one will do the right thing.