[webkit-reviews] review granted: [Bug 75955] Web Inspector: add "free flow DOM editing" experiment. : [Attachment 121836] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 75955: Web Inspector: add "free flow DOM editing" experiment.
https://bugs.webkit.org/show_bug.cgi?id=75955

Attachment 121836: Patch
https://bugs.webkit.org/attachment.cgi?id=121836&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121836&action=review


> Source/WebCore/inspector/DOMEditor.cpp:228
> +	   RefPtr<Node> adoptedNode =
oldParent->ownerDocument()->adoptNode(node, ec);

doesn't insertBefore do adoptNode?

> Source/WebCore/inspector/DOMEditor.h:50
> +    DOMEditor(Document*);

explicit

> Source/WebCore/inspector/DOMEditor.h:56
> +    struct NodeDigest {

Forward declaration should be enough.

> Source/WebCore/inspector/DOMEditor.h:57
> +	   NodeDigest(Node*);

explicit