[webkit-reviews] review granted: [Bug 75885] [Qt][WK2] Fix keyboard shortcuts in MiniBrowser. : [Attachment 121745] patch for review. - same content, but some more ChangeLog.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Zeno Albisser
<zeno at webkit.org>'s request for review:
Bug 75885: [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
https://bugs.webkit.org/show_bug.cgi?id=75885

Attachment 121745: patch for review. - same content, but some more ChangeLog.
https://bugs.webkit.org/attachment.cgi?id=121745&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121745&action=review


> Tools/ChangeLog:10
> +	   In QML events are propagated through parents. But since the
> +	   WebView may consume key events, a shortcut might never reach
> +	   the top QtQuickItem.
> +	   Therefore an application wide event handling function in C++
> +	   needs to take care of shortcuts for MiniBrowser.

Way better... now a small comment in the code would be quite nice. like in the
notify method