[webkit-reviews] review granted: [Bug 75582] [skia] Switch FEColorMatrix filter to use skia's SkColorMatrixFilter : [Attachment 121499] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 75582: [skia] Switch FEColorMatrix filter to use skia's SkColorMatrixFilter
https://bugs.webkit.org/show_bug.cgi?id=75582

Attachment 121499: Patch
https://bugs.webkit.org/attachment.cgi?id=121499&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121499&action=review


Looks a lot better for me. r=me with little changes before landing.

> Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkia.cpp:60
> +    matrix[0] =  0.213f + cosHue * 0.787f - sinHue * 0.213f;
> +    matrix[1] =  0.715f - cosHue * 0.715f - sinHue * 0.715f;
> +    matrix[2] =  0.072f - cosHue * 0.072f + sinHue * 0.928f;

Why are there multiple spaces after the equal sign?

> Source/WebCore/platform/graphics/filters/skia/FEColorMatrixSkia.cpp:64
> +    matrix[5] =  0.213f - cosHue * 0.213f + sinHue * 0.143f;
> +    matrix[6] =  0.715f + cosHue * 0.285f + sinHue * 0.140f;
> +    matrix[7] =  0.072f - cosHue * 0.072f - sinHue * 0.283f;

ditto.