[webkit-reviews] review granted: [Bug 75896] block mask overlay test for CSS3 calc : [Attachment 121734] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Mike Lawther
<mikelawther at chromium.org>'s request for review:
Bug 75896: block mask overlay test for CSS3 calc
https://bugs.webkit.org/show_bug.cgi?id=75896

Attachment 121734: Patch
https://bugs.webkit.org/attachment.cgi?id=121734&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121734&action=review


>
LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html:1
> +<style>

Are you intentionally testing quirks mode? If not, you should have DOCTYPE
here.

>
LayoutTests/css3/calc/block-mask-overlay-image-outset-expected-mismatch.html:12

> +    <div class="blockTest" style="height:0px">
> +	   <div style="height:400px; background-color:grey">This content should
be masked with a soft glow.</div>

Nit: space between ":" and values.

> LayoutTests/css3/calc/block-mask-overlay-image-outset.html:1
> +<style>

Ditto.