[webkit-reviews] review requested: [Bug 75905] REGRESSION(r94902): Disagrees with my view on encoding support in WebKit, and makes refactoring harder (Requested by ap on #webkit). : [Attachment 121753] ROLLOUT of r94902

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 9 17:02:54 PST 2012


Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 75905: REGRESSION(r94902): Disagrees with my view on encoding support in
WebKit, and makes refactoring harder (Requested by ap on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=75905

Attachment 121753: ROLLOUT of r94902
https://bugs.webkit.org/attachment.cgi?id=121753&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
These ifdefs do not have a material effect on any port's runtime behavior, and
make WebKit hacking harder.

We do not want behavior affecting ifdefs in WebCore if at all possible, and we
certainly don't want a port that's used by commit-queue to ifdef out important
functionality that has been known to crash in the past.


More information about the webkit-reviews mailing list