[webkit-reviews] review denied: [Bug 75905] REGRESSION(r94902): Disagrees with my view on encoding support in WebKit, and makes refactoring harder (Requested by ap on #webkit). : [Attachment 121753] ROLLOUT of r94902

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 75905: REGRESSION(r94902): Disagrees with my view on encoding support in
WebKit, and makes refactoring harder (Requested by ap on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=75905

Attachment 121753: ROLLOUT of r94902
https://bugs.webkit.org/attachment.cgi?id=121753&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm trying to understand the motivation for reverting this patch.  Here's my
understanding of the situation:

1) This code is untested.
2) This code only benefits the AppleMac and AppleWin ports.
3) This code violates the RFCs.
4) This code has been known to crash in the past.

My understanding of your point of view is that you prefer to have as few ifdefs
in cross-platform code as possible.

I don't think non-Apple ports should be forced to compile, execute, and
possibly crash in code with these properties.  I support the idea of having
fewer ifdefs is cross-platform code.  Perhaps a better solution is to refactor
this logic so that only Apple port bear the costs of this non-standard,
potentially crashing, code.  We've managed to achieve such things in other
situations without ifdefs.  We might be able to achieve that here as well.