[webkit-reviews] review denied: [Bug 74176] [Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show() crash : [Attachment 121755] Added multiWindow API test and other patch fixes.

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has denied Viatcheslav Ostapenko
<ostapenko.viatcheslav at nokia.com>'s request for review:
Bug 74176: [Qt][WK2]REGRESSION(r102435): It made tst_QQuickWebView::show()
crash
https://bugs.webkit.org/show_bug.cgi?id=74176

Attachment 121755: Added multiWindow API test and other patch fixes.
https://bugs.webkit.org/attachment.cgi?id=121755&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121755&action=review


On the right tracks, but meeds some improvements...

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:127
> +#else

if OS(LINUX/UNIX) ???

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:201
> +	       GLuint shaders[4];

Why 4?

> Source/WebCore/platform/graphics/opengl/TextureMapperGL.cpp:230
> +	       GLContextDataMap::iterator i;

it instead of i

> Source/WebKit2/UIProcess/API/qt/tests/qquickwebview/tst_qquickwebview.cpp:276

> +    showWebView();

The right test for this is not multiple top-level windows, but rather multiple
web-views in the same scene.