[webkit-reviews] review requested: [Bug 74352] [skia] Track a simple opaque area when painting via PlatformContextSkia and save in LayerTextureUpdater : [Attachment 121748] Patch

[bugzilla-daemon at webkit.org]

Dana Jansens <danakj at chromium.org> has asked  for review:
Bug 74352: [skia] Track a simple opaque area when painting via
PlatformContextSkia and save in LayerTextureUpdater
https://bugs.webkit.org/show_bug.cgi?id=74352

Attachment 121748: Patch
https://bugs.webkit.org/attachment.cgi?id=121748&action=review

------- Additional Comments from Dana Jansens <danakj at chromium.org>
This is how I propose we split it out. I've made an OpaqueRegionSkia class in
.../platform/graphics/skia.

The object is pretty dumb itself, it just listens to draws and builds its rect.
You can grab the object back from
the context, and ask for it as a rect with OpaqueRegionSkia::asRect().

The context still have functions to listen to drawing operations and just
forwards them to the OpaqueRegionSkia
when tracking is enabled in the context.

I kept the same unit tests, because I want them to test the GraphicsContextSkia
and other code in
 ...platform/graphics/skia to make sure they are calling the trackDraw*()
methods on the platform
context also.