[webkit-reviews] review granted: [Bug 75713] Cleanup 304 handing after r102602 : [Attachment 121463] patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 75713: Cleanup 304 handing after r102602
https://bugs.webkit.org/show_bug.cgi?id=75713

Attachment 121463: patch
https://bugs.webkit.org/attachment.cgi?id=121463&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121463&action=review


> Source/WebCore/loader/cache/CachedResource.cpp:546
> +    m_switchingClientsToRevalidatedResource = true;

Generally I'm not a big fan of this pattern, mostly because I've seen what it's
done to FrameLoader.  If you think this is the right thing to do here, then I
guess it's ok.

> Source/WebCore/loader/cache/CachedResource.h:304
> +    bool m_switchingClientsToRevalidatedResource : 1;

The : 1 here isn't going to do that much good if there aren't other members to
pack it with.  Maybe skip for now?