[webkit-reviews] review granted: [Bug 64468] WIN: DumpRenderTree hangs under NRWT : [Attachment 121683] Convert Cygwin paths to Windows paths before passing them to DRT
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jan 9 12:20:21 PST 2012
Dirk Pranke <dpranke at chromium.org> has granted Adam Roben (:aroben)
<aroben at apple.com>'s request for review:
Bug 64468: WIN: DumpRenderTree hangs under NRWT
https://bugs.webkit.org/show_bug.cgi?id=64468
Attachment 121683: Convert Cygwin paths to Windows paths before passing them to
DRT
https://bugs.webkit.org/attachment.cgi?id=121683&action=review
------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
I think you probably could have imported webkitpy.common.system.path in
webkit_unittest and then overridden cygpath to point to a mocked-out function,
but I think this is okay, too.
More information about the webkit-reviews
mailing list