[webkit-reviews] review granted: [Bug 75789] defineOwnProperty not implemented for Array objects : [Attachment 121704] Fix

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 75789: defineOwnProperty not implemented for Array objects
https://bugs.webkit.org/show_bug.cgi?id=75789

Attachment 121704: Fix
https://bugs.webkit.org/attachment.cgi?id=121704&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121704&action=review


> Source/JavaScriptCore/JavaScriptCore.exp:5
>
+__ZN3JSC7JSArray17defineOwnPropertyEPNS_8JSObjectEPNS_9ExecStateERKNS_10Identi
fierERNS_18PropertyDescriptorEb
> +__ZN3JSC7JSArray9setLengthEjb
>  _JSCheckScriptSyntax
>  _JSClassCreate
>  _JSClassRelease

Please sort this.

> Source/JavaScriptCore/runtime/JSArray.cpp:261
> +    JSValue value = WriteBarrier<Unknown>::get();

Can you add a typedef of WriteBarrier<Unknown> to Base to make this cleaner.

> Source/JavaScriptCore/runtime/JSArray.h:81
> +	       m_flags = (Flags)(m_flags | LengthIsReadOnly);

This should be a static cast.

> Source/JavaScriptCore/runtime/PropertyDescriptor.h:70
> +	   unsigned attributesOverridingCurrent(const PropertyDescriptor&
current) const;
>      private:

Please put a newline after this function.