[webkit-reviews] review requested: [Bug 73350] [chromium] Allow scrolling non-root layers in the compositor thread : [Attachment 121696] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 9 11:16:43 PST 2012


Sami Kyostila <skyostil at google.com> has asked  for review:
Bug 73350: [chromium] Allow scrolling non-root layers in the compositor thread
https://bugs.webkit.org/show_bug.cgi?id=73350

Attachment 121696: Patch
https://bugs.webkit.org/attachment.cgi?id=121696&action=review

------- Additional Comments from Sami Kyostila <skyostil at google.com>
Thanks James. Here's a rebased patch with the following additional changes:
- Move added methods in ChromeClientImpl.h inside USE(ACCELERATED_COMPOSITING)
- LayerChromium::setMaxScrollPosition() now triggers commit
- Reset currently scrolling layer if the root layer goes away in
CCLayerTreeHostImpl::setRootLayer()

I'll follow up with more test coverage for the cases you mentioned in a
separate bug.


More information about the webkit-reviews mailing list