[webkit-reviews] review granted: [Bug 74652] [CSS Shaders] Move CustomFilterOperation to the platform layer : [Attachment 121671] Patch V3

[bugzilla-daemon at webkit.org]

Chris Marrin <cmarrin at apple.com> has granted Chiculita Alexandru
<achicu at adobe.com>'s request for review:
Bug 74652: [CSS Shaders] Move CustomFilterOperation to the platform layer
https://bugs.webkit.org/show_bug.cgi?id=74652

Attachment 121671: Patch V3
https://bugs.webkit.org/attachment.cgi?id=121671&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=121671&action=review


r=me, but please add text to the test cases so a successful test is obvious
without looking at the pixel results

> LayoutTests/css3/filters/custom-filter-shader-cache-expected.txt:1
> +	

You should really have something output here. At least say something like "Test
of cached custom filter shaders. You should see 12 blocks of color bars, with
increasing lightness from left to right"

> LayoutTests/css3/filters/missing-custom-filter-shader-expected.txt:1
> +    

Same here. At least say something like "Test of missing custom filter shaders.
You should see 5 blocks of color bars, all the same"