[webkit-reviews] review granted: [Bug 73559] Fix OpenGL dependency in CMake build system : [Attachment 121501] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jan 9 09:20:53 PST 2012


Daniel Bates <dbates at webkit.org> has granted Eli Fidler <efidler at rim.com>'s
request for review:
Bug 73559: Fix OpenGL dependency in CMake build system
https://bugs.webkit.org/show_bug.cgi?id=73559

Attachment 121501: Patch
https://bugs.webkit.org/attachment.cgi?id=121501&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121501&action=review


> ChangeLog:8
> +	   Apparently the EFL port uses desktop OpenGL to implement WebGL, but
other ports such as BlackBerry use other libraries like OpenGL ES 2.0 or ANGLE.

> +
> +	   Reviewed by NOBODY (OOPS!).

Nit: These lines should be swapped. Also, we wrap lines to around 80 columns in
change log entries.


More information about the webkit-reviews mailing list