[webkit-reviews] review requested: [Bug 75243] [EFL] Refactor single backing store scroll code. : [Attachment 121262] a patch for using memmove api.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 8 23:42:25 PST 2012


JungJik Lee <jungjik.lee at samsung.com> has asked  for review:
Bug 75243: [EFL] Refactor single backing store scroll code.
https://bugs.webkit.org/show_bug.cgi?id=75243

Attachment 121262: a patch for using memmove api.
https://bugs.webkit.org/attachment.cgi?id=121262&action=review

------- Additional Comments from JungJik Lee <jungjik.lee at samsung.com>
I've tested codes in many cases. Among using memcpy, memmove, memmove in
reverse destination and for-loop to copy the values, the for-loop shows the
worst timelap in any cases. I've tested it under linux x86 and ARM
circumstance. There is not much time gap between memcpy and memmove. Sometimes
memcpy shows the best but it wasn't always. If I consider the code readability,
I think it would be better using memmove only. So as the result, this patch is
not bad as I worried. I add the request to commit-queue again.


More information about the webkit-reviews mailing list