[webkit-reviews] review denied: [Bug 73528] Support the Network Information API : [Attachment 121619] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 8 22:30:32 PST 2012
Adam Barth <abarth at webkit.org> has denied Gyuyoung Kim
<gyuyoung.kim at samsung.com>'s request for review:
Bug 73528: Support the Network Information API
https://bugs.webkit.org/show_bug.cgi?id=73528
Attachment 121619: Patch
https://bugs.webkit.org/attachment.cgi?id=121619&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121619&action=review
> Source/WebCore/page/NetworkInfoConnection.cpp:42
> + ASSERT(!m_frame);
Isn't this ASSERT reading uninitialized memory?
> Source/WebCore/page/NetworkInfoConnection.cpp:43
> + m_frame = frame;
What stops this m_frame point from becoming a dangling reference?
> Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp:63
> +String NetworkInfoClientEfl::networkDeviceType() const
This all looks like code that should be in Platform layer rather than the
WebKit layer.
More information about the webkit-reviews
mailing list