[webkit-reviews] review granted: [Bug 75779] [Texmap] Move surface management from TextureMapperNode to TextureMapper : [Attachment 121565] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Jan 8 14:42:11 PST 2012
Martin Robinson <mrobinson at webkit.org> has granted Noam Rosenthal
<noam.rosenthal at nokia.com>'s request for review:
Bug 75779: [Texmap] Move surface management from TextureMapperNode to
TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=75779
Attachment 121565: Patch
https://bugs.webkit.org/attachment.cgi?id=121565&action=review
------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=121565&action=review
Okay! Please fix the style nit before landing.
> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:136
> + : m_parent(0), m_effectTarget(0), m_opacity(1.0), m_textureMapper(0)
{ }
This should probably be:
TextureMapperNode()
: m_parent(0)
, m_effectTarget(0)
, m_opacity(1),
, m_textureMapper(0)
{
}
Note the style guide suggests remove the .0 from floats when it isn't important
for arithmetic.
More information about the webkit-reviews
mailing list